[ 
https://issues.apache.org/jira/browse/LUCENE-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791591#comment-13791591
 ] 

Michael McCandless commented on LUCENE-5266:
--------------------------------------------

I tested Ryan's patch with Karl's float benchmark (but first I switched it to 
use MMapDir).

Before (4.x):

{noformat}
Scoring 25000000 documents with a lucene value (without square root) source 
took 1361
Scoring 25000000 documents with a lucene value (without square root) source 
took 1344
Scoring 25000000 documents with a lucene value (without square root) source 
took 1338
Scoring 25000000 documents with a lucene value (without square root) source 
took 1373
Scoring 25000000 documents with a lucene value (without square root) source 
took 1344
{noformat}

With Ryan's patch:

{noformat}
Scoring 25000000 documents with a lucene value (without square root) source 
took 1116
Scoring 25000000 documents with a lucene value (without square root) source 
took 1088
Scoring 25000000 documents with a lucene value (without square root) source 
took 1086
Scoring 25000000 documents with a lucene value (without square root) source 
took 1086
Scoring 25000000 documents with a lucene value (without square root) source 
took 1089
{noformat}

It's just a micro-benchmark but it looks like a nice speedup!

> Optimization of the direct PackedInts readers
> ---------------------------------------------
>
>                 Key: LUCENE-5266
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5266
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5266.patch, LUCENE-5266.patch
>
>
> Given that the initial focus for PackedInts readers was more on in-memory 
> readers (for storing stuff like the mapping from old to new doc IDs at 
> merging time), I never spent time trying to optimize the direct readers 
> although it could be beneficial now that they are used for disk-based doc 
> values.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to