[ 
https://issues.apache.org/jira/browse/LUCENE-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-5272:
-------------------------------

    Attachment: LUCENE-5272.patch

I didn't fix all the issues that I raised because I'm not sure what's the best 
course of action here. Clearly, no one relies on these buggy methods so maybe 
we should just fix ensureCapacity for now and worry about OBS's contract 
another day.

If there are no objections, and the patch also seems correct, I will commit 
those changes.

> OpenBitSet.ensureCapacity does not modify numBits
> -------------------------------------------------
>
>                 Key: LUCENE-5272
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5272
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>         Attachments: LUCENE-5272.patch, LUCENE-5272.patch
>
>
> It's a simple bug, reproduced by this simple test:
> {code}
>   public void testEnsureCapacity() {
>     OpenBitSet bits = new OpenBitSet(1);
>     bits.fastSet(0);
>     bits.ensureCapacity(5); // make room for more bits
>     bits.fastSet(2);
>   }
> {code}
> The problem is that {{numBits}} which is used only for assrets isn't modified 
> by ensureCapacity and so the next fastSet trips the assert. I guess we should 
> also fix ensureCapacityWords and test it too.
> I may not be able to fix this until Sunday though, so if anyone wants to fix 
> it before (maybe it can make it into 4.5.1), feel free.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to