[
https://issues.apache.org/jira/browse/LUCENE-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793902#comment-13793902
]
Areek Zillur edited comment on LUCENE-5280 at 10/14/13 3:56 AM:
----------------------------------------------------------------
Given Michael agrees with the above discussion, here is the patch (no
functional changes):
- renamed TermFreqPayloadIterator -> InputIterator (moved from .spell to
.suggest)
- renamed BufferingTermFreqPayloadIteratorWrapper -> BufferedInputIterator
- renamed UnsortedTermFreqPayloadIteratorWrapper -> UnsortedInputIterator
- renamed SortedTermFreqPayloadIteratorWrapper -> SortedInputIterator
- renamed TermWeightPayloadIterator -> DocumentInputIterator (in
DocumentDictionary)
- Got rid of unused imports in DocumentDictionary
- renamed WFSTTermFreqIteratorWrapper -> WFSTInputIterator (in
WFSTCompletionLookup)
- (in tests) renamed TermFreqPayload -> Input
- (in tests) renamed TermFreqPayloadArrayIterator -> InputArrayIterator
- renamed TestTermFreqPayloadIterator -> TestInputIterator
was (Author: areek):
Given Michael agrees with the above discussion, here is the patch (no
functional changes):
- renamed TermFreqPayloadIterator -> InputIterator (moved from .spell to
.suggest)
- renamed BufferingTermFreqPayloadIteratorWrapper -> BufferedInputIterator
- renamed UnsortedTermFreqPayloadIteratorWrapper -> UnsortedInputIterator
- renamed TermWeightPayloadIterator -> DocumentInputIterator (in
DocumentDictionary)
- Got rid of unused imports in DocumentDictionary
- renamed SortedTermFreqPayloadIteratorWrapper -> SortedInputIterator
- (in tests) renamed TermFreqPayload -> Input
- (in tests) renamed TermFreqPayloadArrayIterator -> InputArrayIterator
- renamed TestTermFreqPayloadIterator -> TestInputIterator
> Rename TermFreqPayloadIterator -> SuggestionIterator
> ----------------------------------------------------
>
> Key: LUCENE-5280
> URL: https://issues.apache.org/jira/browse/LUCENE-5280
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.6, 5.0
>
> Attachments: LUCENE-5280.patch
>
>
> The current name is cumbersome, and annoying to change whenever we add
> something to the iterator (in this case payloads). Since we are breaking it
> anyway in 4.6, I think we should take the opportunity to find a better name.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
