On 10/15/13 7:33 PM, Shawn Heisey wrote:
On 10/15/2013 8:11 AM, Yonik Seeley wrote:
On Tue, Oct 15, 2013 at 3:46 AM, Per Steffensen <[email protected]>
wrote:
Is it deliberate that SolrException.log is not used everywhere in
the code
where we log exceptions (Throwables)? Why? Or is it just by accident?
One problem with SolrException.log is that the logger uses that as the
class and method name (assuming those are logged).
Perhaps we would be better off tackling customizations at the logger
level?
I saw calls to SolrException#log when I was finding things for
SOLR-5342. One of the arguments is a logger object. Doesn't that mean
that the log message will actually be output with the class of that
logger?
No
From what I can tell, the only thing you get by using this logging
method is doIgnore. Looking at all the pieces, I don't see what
doIgnore is good for or what exactly it is accomplishing. Can someone
with a better understanding tell me what I'm missing?
I do not see much usage of doIgnore either, but in general I see a
benefit in sending all (exception-)logging through a central/common
place in the code, where you can implement general rules for logging,
that it not easy to do in log-configuration. I gave an example earlier -
that, of course, is only to be used in my local version of Solr (at
least until Apache accept my solution to
optimistic-locking/version-control, but that is probably not going to
happen), but the idea about central/common logging-code in useful in
general.
There seems to be a lot of code duplication between the different log
methods in SolrException, that should be addressed. I could probably
do that.
That would be nice!
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
