[ 
https://issues.apache.org/jira/browse/LUCENE-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802956#comment-13802956
 ] 

Robert Muir commented on LUCENE-5300:
-------------------------------------

I'm not so happy about this:

{code}
   @Override
   public SortedSetDocValues getSortedSet(FieldInfo field) throws IOException {
    if (!ordIndexes.containsKey(field.number)) {
    // if (entry is missing.... look in another place)
{code}

Can we just explicitly write the way the field is encoded instead of the 
fallback? The fallback could be confusing in the case of real bugs.

> SORTED_SET could use SORTED encoding when the field is actually single-valued
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-5300
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5300
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5300.patch
>
>
> It would be nice to detect when a SORTED_SET field is single-valued in order 
> to optimize storage.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to