[ 
https://issues.apache.org/jira/browse/LUCENE-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-5303:
-------------------------------

    Attachment: LUCENE-5303.patch

Patch changes the map to be a WeakHashMap<Object,Map<String,CachedOrds>> so the 
outer map is keyed by reader.getCoreCacheKey() and the inner map is from field 
to CachedOrds, where field is the BinaryDV field which holds the facets 
ordinals.

I also added ramBytesUsed and a test which verifies that ramBytesUsed does not 
change between threads.

> OrdinalsCache should use reader.getCoreCacheKey()
> -------------------------------------------------
>
>                 Key: LUCENE-5303
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5303
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.6, 5.0
>
>         Attachments: LUCENE-5303.patch
>
>
> I'm doing some facet performance tests, and I tried using the 
> CachedOrdsCountingFacetsAggregator to cache the decoded ords per doc X field 
> ... but noticed it was generating way too many cache entries, because it's 
> currently using the NDV instance as the cache key.
> NDV instances are thread-private so this results in way too many entries in 
> the cache.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to