[
https://issues.apache.org/jira/browse/LUCENE-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808150#comment-13808150
]
Adrien Grand commented on LUCENE-5313:
--------------------------------------
I think it is me: when I deprecated
FilteringTokenFilter.setEnablePositionIncrements (because it could break token
streams), I had to give AnalyzingSuggester a way to deal with holes in token
streams (it used to rely on a setEnablePositionIncrements) so I added a setter.
I must admit I haven't thought a lot when doing it and since I was deprecating
a setter, the first idea that came to my mind was to add a setter to the
suggester. However, I agree it would be better to have it as a parameter of the
constructor!
> Add "preservePositionIncrements" to AnalyzingSuggester and FuzzySuggester
> constructors
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-5313
> URL: https://issues.apache.org/jira/browse/LUCENE-5313
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Areek Zillur
> Attachments: LUCENE-5313.patch
>
>
> It would be convenient to have "preservePositionIncrements" in the suggesters
> constructor, rather than having a setPreservePositionIncrements method. That
> way it could be nicely used with the factory model already used by Solr.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
