[
https://issues.apache.org/jira/browse/LUCENE-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814330#comment-13814330
]
Uwe Schindler commented on LUCENE-5283:
---------------------------------------
Hi Dawid,
I was out of offfice, so had no time to review your patch. The current commit
seems to leave the checkout unclean after running tests; my response to the
failure mail:
{quote}
it looks like Dawid's commit placed these .tests.totals files in the wrong
directory. Should be inside build! Maybe some property is incorrectly
initialized.
In addition I will add another comment to the corresponding issue, because of
some dependency of the commit to javascript, that’s not fully guaranteed to be
available in every JVM (e.g., on FreeBSD we don't have it).
{quote}
The second thing is a problem on some platforms. We discussed about that
already in the past (you know I was fighting pro Javascript), but other
convinced me: Javascript is not guaranteed to be a available on every JDK (the
JDK only defines the abstract script interface and mandates that some example
script engine is avilable, but not which one). So I changed all scripts in out
ANT build to use groovy. For Groovy, ideally use the <groovy/> ant task
(installed by common-build when you depend on the corresponding install-groovy
task. You can also use it with <scriptcondition/> or <script/> but this leads
to permgen problems when called in every module. The reason for this is:
<script/> creates a new classloader every time and loads a new groovy, while
installing the <groovy/> ant task can be reused in sub-modules (so we only need
to install top-level).
So I would rewrite the <scriptcondition> to a simple <groovy/> executed before
the condition task, which sets a property thats used by the condition. Or
alternatively directly throw a BuildException in the groovy without using a
scriptcondition at all.
I can provide a patch tomorrow.
> Fail the build if ant test didn't execute any tests (everything filtered out).
> ------------------------------------------------------------------------------
>
> Key: LUCENE-5283
> URL: https://issues.apache.org/jira/browse/LUCENE-5283
> Project: Lucene - Core
> Issue Type: Wish
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 4.6, 5.0
>
> Attachments: LUCENE-5283.patch, LUCENE-5283.patch
>
>
> This should be an optional setting that defaults to 'false' (the build
> proceeds).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
