[ 
https://issues.apache.org/jira/browse/LUCENE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817068#comment-13817068
 ] 

Robert Muir commented on LUCENE-5335:
-------------------------------------

I dont think things like SumTotalTermFreqValueSource should be a blocker to 
fixing this map API, actually I think a cleaner API here is really needed.

Look at DocFreqValueSource for example, it screws this up: if you have 30 
segments it will call docFreq for the term 900 times. Same goes with 
IDFValueSource and many of these other things.

These "top level" valuesources should be implemented in a cleaner and 
consistent way that is not slow.


> Change raw Map type to Map<String,Object> for ValueSource context
> -----------------------------------------------------------------
>
>                 Key: LUCENE-5335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5335
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-5335.patch
>
>
> Just as the title says.  Simple refactoring.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to