Dawid: Why I'd like to run the suite from the top level: Mostly being lazy. When I see a test case failure I can be stupid, go to root and execute it. Now I have to, you know, pay attention or something.
I'm all for making maintenance simpler, especially since I have no desire whatsoever to get into the build code ;). I have no problem leaving it as it is. We do need to let people know about the change though. Perhaps an error message very early when -Dtestcase= is detected directing users that this option is not valid from root any more? I'll update the "how to contribute" page which gives wrong instructions now, any other documentation we need to change? Erick On Fri, Nov 15, 2013 at 2:56 AM, Dawid Weiss <[email protected]>wrote: > People, calm down. > > ant -Dtestcase= > > was only meant to work from lucene/ or solr/ level. This is not a bug, > it was done (by me) on purpose to avoid introducing a lot of > complexity currently residing in common-* to the top-level build > script. > > The easiest way to fix this would be to disallow testcase filtering at > the top level (can you explain me why you'd want to run a full test > suite of both solr and lucene just to filter for a particular test > case)? I'll see what I can do to make it work from the top-level. > > Dawid > > > On Fri, Nov 15, 2013 at 3:27 AM, Erick Erickson <[email protected]> > wrote: > > I'm soooo glad somebody else is seeing this. I was having deep thoughts > > about advancing senility..... > > > > Erick > > > > > > On Thu, Nov 14, 2013 at 9:12 PM, Chris Hostetter < > [email protected]> > > wrote: > >> > >> > >> I'm pretty sure this is a bug in the LUCENE-5283 changes... > >> > >> > >> > https://issues.apache.org/jira/browse/LUCENE-5283?focusedCommentId=13823212&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13823212 > >> > >> > >> : Date: Thu, 14 Nov 2013 18:49:36 -0700 > >> : From: Shawn Heisey <[email protected]> > >> : Reply-To: [email protected] > >> : To: [email protected] > >> : Subject: Re: I simply cannot be the only one seeing this.... > >> : > >> : On 11/14/2013 6:33 PM, Erick Erickson wrote: > >> : > Every time I try try to run an individual test, I get "no tests > ran". > >> E.g. > >> : > ant -Dtestcase=AddBlockUpdateTest test > >> : > and I get > >> : > /Users/Erick/apache/4x_5441/build.xml:39: The following error > occurred > >> while > >> : > executing this line: > >> : > /Users/Erick/apache/4x_5441/lucene/common-build.xml:1281: Not even a > >> single > >> : > test was executed (a typo in the filter pattern maybe)? > >> : > > >> : > Has something changed here? Or am I just totally in a fog and doing > >> : > something silly? > >> : > >> : If I run your command example from the root of the branch_4x > checkout, I > >> get > >> : the same error. If I "cd solr" and then do it again, it runs the > >> requested > >> : testcase and the build succeeds. > >> : > >> : In the past, I know that Solr tests have been disabled to eliminate > >> jenkins > >> : noise. I don't remember seeing anything recent to indicate that's > >> happened > >> : again, but something's definitely odd. > >> : > >> : Thanks, > >> : Shawn > >> : > >> : > >> : --------------------------------------------------------------------- > >> : To unsubscribe, e-mail: [email protected] > >> : For additional commands, e-mail: [email protected] > >> : > >> : > >> > >> -Hoss > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
