[ 
https://issues.apache.org/jira/browse/SOLR-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830834#comment-13830834
 ] 

Mark Miller edited comment on SOLR-5496 at 11/24/13 2:26 AM:
-------------------------------------------------------------

bq. Did you mean to make similar changes in HttpShardHandlerFactory as well? I 
see an import of the pooling client in there, but no other changes?

Do you have something in mind? It seemed it was fairly well behaved - eg one 
poolingconectionmanager and one http client.

I figure it should be a separate http client from update since you can do 
different timeouts.

I'm certainly open to sharing the connection manager across both ...

I just wanted to get jenkins take on these changes, but ready to do some 
iteration if you have some thoughts.


was (Author: [email protected]):
bq. Did you mean to make similar changes in HttpShardHandlerFactory as well? I 
see an import of the pooling client in there, but no other changes?

Do you have something in mind? It seemed it was fairly well behaved - eg one 
poolingconectionmanager and one http client.

I figure it should be a separate http client from update since you can do 
different timeouts.

I'm certainly open to sharing the connection manager across both ...

I just wanted to get jenkins take on these changes, but ready to some iteration 
if you have some thoughts.

> We should share an http connection manager across most non search httpclients 
> and ensure all http connection managers get shutdown.
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5496
>                 URL: https://issues.apache.org/jira/browse/SOLR-5496
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-5496.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to