[ 
https://issues.apache.org/jira/browse/SOLR-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikhar Bhushan updated SOLR-5505:
----------------------------------

    Attachment: SOLR-5505.patch

Attaching patch against trunk.

It does something different than what I proposed earlier:

a) {{LoggingInfoStream}} constructor takes the slf4j {{Logger}} instance to be 
used as a constructor param.

b) {{SolrIndexConfig}} checks if there is a "loggerName" configuration 
attribute on the "infoStream" tag, and if so this is used as the name for the 
{{Logger}}. Otherwise, the previous default of the {{LoggingInfoStream}} class 
name is used. This will enable users to manage the log output using their 
logging subsystem, e.g. the formatting pattern, to what log file etc.

b) Additionally, I removed logging of the thread name from within 
{{LoggingInfoStream}}, since this is commonly configured at the level of the 
formatting patter for a logger.

> LoggingInfoStream not usabe in a multi-core setup
> -------------------------------------------------
>
>                 Key: SOLR-5505
>                 URL: https://issues.apache.org/jira/browse/SOLR-5505
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.6
>            Reporter: Shikhar Bhushan
>         Attachments: SOLR-5505.patch
>
>
> {{LoggingInfoStream}} that was introduced in SOLR-4977 does not log any core 
> context.
> Previously this was possible by encoding this into the infoStream's file path.
> This means in a multi-core setup it is very hard to distinguish between the 
> infoStream messages for different cores.
> {{LoggingInfoStream}} should be automatically configured to prepend the core 
> name to log messages.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to