[ 
https://issues.apache.org/jira/browse/SOLR-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840058#comment-13840058
 ] 

Erick Erickson commented on SOLR-5528:
--------------------------------------

Areek:

That works for me!

My suggestions (pun intended) were leveraging off the fact that it "just works" 
now, it would be the minimum effort to add in the name. That said, I wasn't 
really _happy_ with the fact that the "name" elements had to be the same for 
the different components or you get a mysterious NPE (<str 
name="name">suggest</str>). That indicated that this wasn't thought-out, just 
happenstance and thus quite possibly fragile.

But I can't put the effort into finding out why or fixing in the near future, 
so I was punting. Your idea is much cleaner and I'll be happy to help work on 
it...when I can which won't be for some time.

Go for it!

Erick

> Change New Suggester Response and minor cleanups
> ------------------------------------------------
>
>                 Key: SOLR-5528
>                 URL: https://issues.apache.org/jira/browse/SOLR-5528
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Areek Zillur
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-5528.patch
>
>
> It would be nice to have a simplified response format for the new Suggester 
> Component. 
> The proposed format is as follows:
> XML: 
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <response>
>    <lst name="responseHeader">
>       <int name="status">0</int>
>       <int name="QTime">32</int>
>    </lst>
>    <str name="command">build</str>
>    <lst name="suggest">
>       <lst name="ele">
>          <int name="numFound">1</int>
>          <arr name="suggestions">
>             <lst>
>                <str name="term">electronics and computer1</str>
>                <long name="weight">2199</long>
>                <str name="payload" />
>             </lst>
>          </arr>
>       </lst>
>    </lst>
> </response>
> {code}
> JSON:
> {code}
> {
>     "responseHeader": {
>         "status": 0,
>         "QTime": 30
>     },
>     "command": "build",
>     "suggest": {
>         "ele": {
>             "numFound": 1,
>             "suggestions": [
>                 {
>                     "term": "electronics and computer1",
>                     "weight": 2199,
>                     "payload": ""
>                 }
>             ]
>         }
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to