[ 
https://issues.apache.org/jira/browse/SOLR-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854380#comment-13854380
 ] 

Michael McCandless commented on SOLR-5553:
------------------------------------------

This seems like a lucene issue; I'll rename it, and we should fix the tests to 
be Lucene-level tests...

I agree it'd be useful to detect mis-use but I don't like the added cost this 
imposed on correct usage.  I wonder if there's a more best-effort approach we 
could take.

If you enable assertions, without adding the validateParents, do the tests trip 
the existing assertions?

> ToChildBlockJoinQuery becomes crazy on wrong subquery
> -----------------------------------------------------
>
>                 Key: SOLR-5553
>                 URL: https://issues.apache.org/jira/browse/SOLR-5553
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.6
>            Reporter: Dr Oleg Savrasov
>              Labels: patch
>         Attachments: SOLR-5553.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> If user supplies wrong subquery to ToParentBlockJoinQuery it reasonably 
> throws IllegalStateException. 
> (http://lucene.apache.org/core/4_0_0/join/org/apache/lucene/search/join/ToParentBlockJoinQuery.html
>  'The child documents must be orthogonal to the parent documents: the wrapped 
> child query must never return a parent document.'). However 
> ToChildBlockJoinQuery just goes crazy silently. I want to provide simple 
> patch for ToChildBlockJoinQuery with if-throw clause and test.
> See 
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201311.mbox/%[email protected]%3E



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to