[
https://issues.apache.org/jira/browse/SOLR-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860188#comment-13860188
]
YouPeng Yang commented on SOLR-5580:
------------------------------------
It needs to make clear that ,I create a collection with the new solr 4.6.
We deploy the new solr 4.6 in tomcat, and just create a new collection and a
new core with the same request URL.
Collections can created when we create a new with no explicit corenodename , I
can not find the autocreated property in the collection information on
zookeeper.
Convenient to manage the core,we would like to identify core with explicit
custom shard name, core name ,collection and corecodename.
You said that I need to create a slice first which I think is not convenient.
As all things go well in the old version. I think with no defend your work
maybe make the lose of solr flexibility and the smooth.
Anyway , we do hope your work keeps the good feature of solr.
Another suggestion ,if you make any change about the good charecter of solr
,please give some hints in the reference doc or CHANGES.
The last thing ,what is the purpose of the autocreated check . The
autocreated property can not be find in solr. I have checked the data in
zookeeper.
Oh, even there are no any information about the change.
发自我的 iPhone
在 2014-1-2，20:04，"Noble Paul (JIRA)" <[email protected]> 写道：
> SOLR-5311 was done without full understanding of the system and must be
> reverted.
> ---------------------------------------------------------------------------------
>
> Key: SOLR-5580
> URL: https://issues.apache.org/jira/browse/SOLR-5580
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.6
> Environment: OS:Red Hat Enterprise Linux Server release 6.4 (Santiago)
> Software:solr 4.6,
> jdk:OpenJDK Runtime Environment (rhel-2.3.4.1.el6_3-x86_64)
> OpenJDK 64-Bit Server VM (build 23.2-b09, mixed mode)
> Reporter: YouPeng Yang
> Assignee: Mark Miller
> Labels: core
> Fix For: 5.0, 4.7, 4.6.1
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In class org.apache.solr.cloud.Overseer the Line 360:
> ---------------------------------------------------------------------
> if (sliceName !=null && collectionExists &&
> !"true".equals(state.getCollection(collection).getStr("autoCreated"))) {
> Slice slice = state.getSlice(collection, sliceName);
> if (slice.getReplica(coreNodeName) == null) {
> log.info("core_deleted . Just return");
> return state;
> }
> }
> ---------------------------------------------------------------------
> the slice needs to be checked null .because when create a new core with both
> explicite shard and coreNodeName, the state.getSlice(collection, sliceName)
> may return a null.So it needs to be checked ,or there will be an
> NullpointException
> ---------------------------------------------------------------------
> if (sliceName !=null && collectionExists &&
> !"true".equals(state.getCollection(collection).getStr("autoCreated"))) {
> Slice slice = state.getSlice(collection, sliceName);
> if (slice != null && slice.getReplica(coreNodeName) == null) {
> log.info("core_deleted . Just return");
> return state;
> }
> }
> ---------------------------------------------------------------------
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
