Some things work well, some things do not. Things that work: * when pull request is opened, it goes to the dev@ list * when committed to svn, its referenced correctly in the pull request via the github mirror.
Things that dont work: * comments on pull requests dont go to the dev@ list. i'm not happy about this. maybe we can somehow auto-subscribe it? * i have no idea how to close the request, i dont think i have the appropriate permissions? Please see https://github.com/apache/lucene-solr/pull/11 for more details. On Sat, Jan 4, 2014 at 11:49 AM, Uwe Schindler <[email protected]> wrote: > Thanks for testing this out! > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] >> Sent: Saturday, January 04, 2014 5:44 PM >> To: [email protected] >> Subject: svn commit: r1555367 - in /lucene/dev/trunk/solr: CHANGES.txt >> core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java >> core/src/java/org/apache/solr/highlight/SolrHighlighter.java >> >> Author: rmuir >> Date: Sat Jan 4 16:43:32 2014 >> New Revision: 1555367 >> >> URL: http://svn.apache.org/r1555367 >> Log: >> pull request #11: change the default of hl.phraseLimit to 5000 >> >> Modified: >> lucene/dev/trunk/solr/CHANGES.txt >> >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/DefaultSolrH >> ighlighter.java >> >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/SolrHighlight >> er.java >> >> Modified: lucene/dev/trunk/solr/CHANGES.txt >> URL: >> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=155 >> 5367&r1=1555366&r2=1555367&view=diff >> ========================================================== >> ==================== >> --- lucene/dev/trunk/solr/CHANGES.txt (original) >> +++ lucene/dev/trunk/solr/CHANGES.txt Sat Jan 4 16:43:32 2014 >> @@ -261,6 +261,9 @@ Other Changes >> * SOLR-5590: Upgrade HttpClient/HttpComponents to 4.3.x. >> (Karl Wright via Shawn Heisey) >> >> +* pull request #11: change the default of hl.phraseLimit to 5000. >> + (Michael Della Bitta via Robert Muir) >> + >> ================== 4.6.1 ================== >> >> Versions of Major Components >> >> Modified: >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/DefaultSolrH >> ighlighter.java >> URL: >> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apa >> che/solr/highlight/DefaultSolrHighlighter.java?rev=1555367&r1=1555366&r2= >> 1555367&view=diff >> ========================================================== >> ==================== >> --- >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/DefaultSolrH >> ighlighter.java (original) >> +++ >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/DefaultSolrH >> ighlighter.java Sat Jan 4 16:43:32 2014 >> @@ -399,7 +399,7 @@ public class DefaultSolrHighlighter exte >> params.getBool( HighlightParams.USE_PHRASE_HIGHLIGHTER, true ), >> // FVH cannot process hl.requireFieldMatch parameter per-field basis >> params.getBool( HighlightParams.FIELD_MATCH, false ) ); >> - fvh.setPhraseLimit(params.getInt(HighlightParams.PHRASE_LIMIT, >> Integer.MAX_VALUE)); >> + fvh.setPhraseLimit(params.getInt(HighlightParams.PHRASE_LIMIT, >> SolrHighlighter.DEFAULT_PHRASE_LIMIT)); >> FieldQuery fieldQuery = fvh.getFieldQuery( query, >> searcher.getIndexReader() ); >> >> // Highlight each document >> >> Modified: >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/SolrHighlight >> er.java >> URL: >> http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apa >> che/solr/highlight/SolrHighlighter.java?rev=1555367&r1=1555366&r2=155536 >> 7&view=diff >> ========================================================== >> ==================== >> --- >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/SolrHighlight >> er.java (original) >> +++ >> lucene/dev/trunk/solr/core/src/java/org/apache/solr/highlight/SolrHighlight >> er.java Sat Jan 4 16:43:32 2014 >> @@ -34,6 +34,8 @@ import org.apache.solr.util.SolrPluginUt >> >> public abstract class SolrHighlighter >> { >> + >> + public static int DEFAULT_PHRASE_LIMIT = 5000; >> public static Logger log = LoggerFactory.getLogger(SolrHighlighter.class); >> >> @Deprecated > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
