[
https://issues.apache.org/jira/browse/LUCENE-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863266#comment-13863266
]
Steve Rowe commented on LUCENE-5383:
------------------------------------
bq. github accepts GH-xxx as well as #xxx (see
http://stackoverflow.com/a/6742691)
+1, though the Github blog linked to from that SO post -
https://github.com/blog/411-github-issue-tracker - only talks about the issue
tracker, not pull requests. This fuzziness (allowing pull requests to work the
same as issues) seems intentional, AFAICT, so it's likely that "closes GH-12"
will close pull request #12.
I'll modify the patch to recognize GH-xxx too.
> fix changes2html to link pull requests
> --------------------------------------
>
> Key: LUCENE-5383
> URL: https://issues.apache.org/jira/browse/LUCENE-5383
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-5383.patch
>
>
> If someone submits a pull request, i think we should put it in changes.txt in
> some way similar to the jira issues:
> e.g. for a JIRA issue we do:
> {noformat}
> * LUCENE-XXXX: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> changes2html recognizes and expands these to jira issue links.
> so I think we should be able to do something like:
> {noformat}
> * pull request #xxx: Add FooBar. (Joe Contributor via John Committer)
> {noformat}
> and have it link to the request, too.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
