Steven Bower created SOLR-5616:
----------------------------------

             Summary: Make grouping code use response builder needDocList
                 Key: SOLR-5616
                 URL: https://issues.apache.org/jira/browse/SOLR-5616
             Project: Solr
          Issue Type: Bug
            Reporter: Steven Bower


Right now the grouping code does this to check if it needs to generate a 
docList for grouped results:

{code}
if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT, 
false) ){
...
}
{code}

this is ugly because any new component that needs a doclist, from grouped 
results, will need to modify QueryComponent to add a check to this if. Ideally 
this should just use the rb.isNeedDocList() flag...

Coincidentally this boolean is really never used at for non-grouped results it 
always gets generated..



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to