If the fix you pushed is the small change to the solution and not a change to the actual code, I'd say it's not big enough to recut. Also the empty directory is pretty low... I'll leave the vote open a bit longer, and we can summarize the +1s and review these issues if we think they warrant a re-cut.
> Date: Mon, 1 Oct 2012 22:03:20 +0200 > Subject: Re: [Vote] Apache Lucene.Net 3.0.3 (Take 2) > From: [email protected] > To: [email protected] > > A perfectionist's -1 > > I pushed a small fix to trunk, plus if you could please remove the folder > at src\contrib\Spatial\Utils - it's an empty dir and git-svn isn't nice to > me lately > > Can you also stage the nuget packages for review and to a vote? > > On Mon, Oct 1, 2012 at 1:18 AM, Prescott Nasser <[email protected]>wrote: > > > Alright, made updates to the binary releases to include the .pdb as well > > as missing Spatial.NTS binaries. I didn't change anything about the source > > files, which is why I didn't upgrade the number to RC2. > > > > Again if you don't mind: > > > > +1 go go go > > 0 eh.. > > -1 still have a few issues. > > > > Please review the source and binaries to make sure we're not missing > > anything - doing this with a half year in between doesn't make me super > > confident I've got it 100% right. > > > > ~P > >
