This sounds very good. I'm holding off on this effort for a bit now as we are awaiting clearance on some CLA issue we have with the contributed code. I hope this will get clarified ASAP and we could merge the code in.
You are more than welcome to take the code from here https://github.com/synhershko/lucene.net/tree/Lucene.Net_4.8.0 and start digging into some of the failing tests,I could definitely use some help with fixing them -- Itamar Syn-Hershko http://code972.com | @synhershko <https://twitter.com/synhershko> Freelance Developer & Consultant Author of RavenDB in Action <http://manning.com/synhershko/> On Mon, Aug 25, 2014 at 5:12 PM, Rahul Singh (ANANT) <rahul.si...@anant.us> wrote: > Gentlemen, > > Thanks for the great work on porting the latest Lucene. I have been working > with the binary builds of Lucene.NET and after digging deep into the latest > Java versions. > > I was thinking of contributing in the following ways : > > 1. Better documentation / examples / etc. > 2. Regression Testing / Integration Testing > 3. Bug Fixes > 4. Anything else. > > I wanted to get involved earlier but it's been a busy summer of work. > > Rahul > > > Rahul Singh | Internet Architect & Partner > > To empower people through the Internet to create a better world. > > How are we doing? Please take our survey > <http://links.anant.us/customerfeedbacksurvey> > > Anant | http://anant.us > 1010 Wisconsin Ave NW, Suite 250 > Washington, D.C. 20007 > > o 1.855.ANANTCO x101 | m 202.905.2818 | t @xingh > <http://www.twitter.com/xingh> | li xingh < > http://www.linkedin.com/in/xingh> | > fb rahul.singh <http://www.facebook.com/rahul.singh> > > *This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Anant Corporation . If you are not the intended > recipient of this email, you must neither take any action based upon its > contents, nor copy or show it to anyone. Please contact the sender if you > believe you have received this email in error.* > > > On Wed, Aug 13, 2014 at 2:21 PM, Itamar Syn-Hershko <ita...@code972.com> > wrote: > > > Awesome. I'm still making progress on fixing tests on my branch, so make > > sure you rebase every now and then. > > > > -- > > > > Itamar Syn-Hershko > > http://code972.com | @synhershko <https://twitter.com/synhershko> > > Freelance Developer & Consultant > > Author of RavenDB in Action <http://manning.com/synhershko/> > > > > > > On Wed, Aug 13, 2014 at 8:46 PM, Simon Svensson <si...@devhost.se> > wrote: > > > > > Hi, > > > > > > I got mentally preoccupied by work once again... > > > > > > I've forked the code and see the failing tests. Some tests seems to > > > randomly hang, guessing due to the thread-lock-issues mentioned > > previously. > > > There are a few failing tests which targets easier areas, like > > > query-parsing/objects. I will take a look at those issues to get > familiar > > > with everything. (Hopefully also fixing something...) > > > > > > // Simon > > > > > > > > > On 11/08/14 09:25, Itamar Syn-Hershko wrote: > > > > > >> Great! > > >> > > >> There's no such thing as "contrib" anymore, fwiw. You should clone my > > repo > > >> and work on that until Prescott / Troy sort out the CLAs. > > >> > > >> With regards to what you can work on - there are many failing tests, > > some > > >> of them are in the analysis area. You can either start poking around > > >> trying > > >> to fix those tests, or start porting the analyzers, highlighter, etc > > >> packages. The idea is to have Lucene.Net.Analyzers, > > Lucene.Net.Highlighter > > >> etc packages - a package here: > > >> https://github.com/synhershko/lucene.net/tree/Lucene.Net_4.8.0/src > > (where > > >> core will be renamed to Lucene.Net later, I just don't want to lose > git > > >> history now) for every package here: > > >> https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene > > >> > > >> Does that make sense? > > >> > > >> -- > > >> > > >> Itamar Syn-Hershko > > >> http://code972.com | @synhershko <https://twitter.com/synhershko> > > >> > > >> Freelance Developer & Consultant > > >> Author of RavenDB in Action <http://manning.com/synhershko/> > > >> > > >> > > >> On Mon, Aug 11, 2014 at 10:13 AM, Simon Svensson <si...@devhost.se> > > >> wrote: > > >> > > >> Hi, > > >>> > > >>> I feel like I'm mostly lurking in a highly unproductive way; time to > > >>> change that! > > >>> > > >>> I would like to spend more time with the code, but do not know where > to > > >>> start and what to focus on. I'm proficient in C# and everything > > related, > > >>> but the inner workings of the lucene core is shrouded in mystery. I > > guess > > >>> that places me in the contrib/analyzers/documentation area. > > >>> > > >>> So, since I'm in need of some guidance; > > >>> 1) What should I focus on? > > >>> 2) Should I fork Itamar's bransch and send pull-requests to it? > > >>> > > >>> // Simon > > >>> > > >>> > > >>> > > >>> On 08/08/14 05:34, Itamar Syn-Hershko wrote: > > >>> > > >>> Hi all. > > >>>> > > >>>> I've been working on the 4.8 branch to try and stabilize it so it > can > > be > > >>>> the base for our next release. There's still plenty to do, but I was > > >>>> able > > >>>> to make decent progress. > > >>>> > > >>>> This thread will be used for me to report progress and hopefully get > > >>>> some > > >>>> more people involved. > > >>>> > > >>>> My branch is here: https://github.com/synhershko/ > > >>>> lucene.net/tree/Lucene.Net_4.8.0 > > >>>> > > >>>> Out of about 2300 tests currently, there are about 600 failing tests > > and > > >>>> the rest are green. At least 300 of the failing tests are due to > > missing > > >>>> codecs (some codecs haven't been ported yet). The rest of the > failures > > >>>> can > > >>>> be largely categorized as below. > > >>>> > > >>>> 1. The missing codecs need to be ported (into a separate assembly). > > >>>> There > > >>>> isn't too much of code to port and work is pretty much self > contained. > > >>>> However completing this will make about 300 tests green. > > >>>> The code to port is here: https://github.com/apache/ > > >>>> lucene-solr/tree/lucene_solr_4_8_0/lucene/codecs/src/java/ > > >>>> org/apache/lucene/codecs > > >>>> > > >>>> 2. Compressed fields implementation is largely broken. Quite a few > > test > > >>>> are red and I'm pretty sure the fix is quite simple, just a faulty > > >>>> implementation to quickly re-write. > > >>>> > > >>>> 3. Many, many tests are very slow or even deadlocking because of > > >>>> threading issues. Culprits are both IndexWriter and FSDirectory. > This > > is > > >>>> the most severe and probably challenging issue to solve. > > >>>> There are multiple failures which I believe relate to this issue. > > >>>> "Access > > >>>> to the path is denied." on index files, failing Asserts etc. > > >>>> > > >>>> 4. The fsync implementation (in FSDirectory) needs some love and > > >>>> testing. > > >>>> > > >>>> 5. The rest of the failing tests are probably isolated porting > issues > > >>>> (Java / C# differences or bugs introduced while porting). I > attached a > > >>>> screenshot of one such error, thrown using Debug.Assert from the > core > > >>>> while > > >>>> running some of the tests. > > >>>> > > >>>> Other items to tackle later: > > >>>> > > >>>> 1. CLS compliance. Maybe the biggest item there is the byte/sbyte > > thing > > >>>> we discussed several times before. > > >>>> > > >>>> 2. Porting the contribs. > > >>>> > > >>>> 3. Cleaning up the API and XML comments > > >>>> > > >>>> 4. Fixing the license header in all source files > > >>>> > > >>>> 5. CI pipeline and SlowTest attribute to have some tests run only on > > >>>> nightly builds or similar > > >>>> > > >>>> Anyone up for some coding? > > >>>> > > >>>> -- > > >>>> > > >>>> Itamar Syn-Hershko > > >>>> http://code972.com <http://code972.com/> | @synhershko < > > >>>> https://twitter.com/synhershko> > > >>>> Freelance Developer & Consultant > > >>>> Author of RavenDB in Action <http://manning.com/synhershko/> > > >>>> > > >>>> > > >>>> > > > > > >
