Thanks, its actually a change I forgot to commit. Did that now. --
Itamar Syn-Hershko http://code972.com | @synhershko <https://twitter.com/synhershko> Freelance Developer & Consultant Author of RavenDB in Action <http://manning.com/synhershko/> On Tue, Sep 9, 2014 at 1:43 AM, Prad Nelluru <[email protected]> wrote: > So, if I'm understanding this process correctly: > 1) I send a PR to GitHub > 2) The PR is mirrored to Apache > 3) You merge at Apache > 4) GitHub then gets the changes periodically as part of the mirroring > process > > Okay, I think I can get started now. > > I've sent a small change now to fix a build issue: > https://github.com/apache/lucene.net/pull/17 > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On > Behalf Of Itamar Syn-Hershko > Sent: Monday, September 8, 2014 3:34 PM > To: [email protected] > Subject: Re: Introducing myself > > Sounds good! > > It works almost like you described. Tracking PRs on GitHub is very easy so > this is why I told you to send them there, but we will actually merge them > with the Apache servers (which then in turn are mirrored to GitHub). > > Please make sure your commits and PRs are as focused as possible, that > would help us merge them in faster. > > -- > > Itamar Syn-Hershko > http://code972.com | @synhershko <https://twitter.com/synhershko> > Freelance Developer & Consultant Author of RavenDB in Action < > http://manning.com/synhershko/> > > On Tue, Sep 9, 2014 at 1:05 AM, Prad Nelluru <[email protected]> wrote: > > > Hi Itamar and Prescott, > > > > I've signed the ICLA and sent it to Apache. I'm unsure how long it'll > > take for all that be approved and done. > > > > I'm going to start sending changes to the GitHub mirror using the > > following process: > > 1. I'll make a fork of the repo at > > https://github.com/apache/lucene.net > > 2. I'll make changes and commit them > > 3. I'll send a pull request once I’m done with a specific set of > > changes 4. At this point, one of the committers like Itamar will merge > > the changes in. > > > > Does this sound good? I'm new to Git and am a little unsure how the > > mirroring between GitHub and Apache's git server works. I'm assuming > > that once changes are made to the GitHub, they will be sent to Apache > > soon thereafter. > > > > I'll start sending the changes as I make them. > > > > Thanks for the warm welcome, > > Prad > > > > -----Original Message----- > > From: [email protected] [mailto:[email protected]] > > On Behalf Of Itamar Syn-Hershko > > Sent: Saturday, September 6, 2014 12:42 PM > > To: [email protected] > > Subject: Re: Introducing myself > > > > Hi, thanks for taking over this. > > > > I have literally just merged Russell's, Prescott's and my changes to > > the master branch of the main repo for this project. That'd be git:// > > git.apache.org/lucene.net.git with a mirror at > > https://github.com/apache/lucene.net (note the mirror has some > > mirroring latency). > > > > I'm going to post more details about this in another thread, but in > short: > > I was able to fix many tests but still quite a few remaining. We will > > be happy to receive more help from you and your team, but please if > > you could sign the ICLA asap so we can merge your changes in quickly. > > > > I'm also working on tests and other areas, but that shouldn't stop you. > > Please make sure you commit to a fork with clear and concise commit > > messages, and then we could just merge your changes in as they come. > > > > So in short: please fork the Apache Lucene.NET repo and work off the > > master branch, work on fixing whatever tests you want, and send pull > > requests to either my branch or here: > > https://github.com/apache/lucene.net/pulls. > > > > Thanks again and welcome. > > > > -- > > > > Itamar Syn-Hershko > > http://code972.com | @synhershko <https://twitter.com/synhershko> > > Freelance Developer & Consultant Author of RavenDB in Action < > > http://manning.com/synhershko/> > > > > > > On Sat, Sep 6, 2014 at 2:19 AM, Prad Nelluru <[email protected]> > wrote: > > > > > Hey everyone, > > > > > > I recently joined Souren Aghajanyan's team at Microsoft. I've taken > > > over the work that Russell had been doing on porting Lucene. My main > > > concern at the moment is to get the unit tests passing, with high > > > priority being given to index, store, util, and search tests. > > > > > > The devs who are working on the tests (like me) should work together > > > to tackle the unit tests in an organized fashion. Who else is > > > working on > > them? > > > > > > I'm currently working on the code with our internal source control. > > > It would be beneficial if I start contributing to the main repo that > > > the project is using. Is synsherko's repo ( > > > https://github.com/synhershko/lucene.net/tree/Lucene.Net_4.8.0/) the > > > one we're currently working on? I'd like to reconcile the changes > > > I've made to the unit tests soon so we're all on the same page. > > > > > > Thanks, > > > Prad Nelluru > > > > > >
