GitHub user laimis opened a pull request:
https://github.com/apache/lucenenet/pull/42
remove unnecessary byte buffer
Fixes null reference exception that can be observed at times in some of the
TestCompressingStoredFieldsFormat and TestCompressingTermVectorsFormat tests.
The issue is that those tests set Codec to CompressingCodec using
CompressingCodec.RandomInstance which can result in
HighCompressionCompressingCodec being used. HighCompressionCompressingCodec in
turn uses decompressor that has a bug. The fix removes instantiation of a
separate byte buffer in the Inflater and instead uses the buffer that was
provided in the call. Instantiating a new buffer essentially wrote bits to an
array that no upstream code used. So the callers were getting empty bytes
buffer back always. There might be more test that were affected by this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laimis/lucenenet Inflater_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 39ae8f9f0ec9705a81f736215123e73964f6ef07
Author: Laimonas Simutis <[email protected]>
Date: 2015-01-05T01:26:47Z
remove unnecessary byte buffer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
