hmmm, I didn't touch the Facet project. refs could have dropped amid all the commits. As for Grouping, I just ported it but haven't had a chance to clean it up. They were ported a couple months back from v4.8 of Lucene Java. All who are working on the newly ported projects pls refer to the Java code while doing so. Make sure you use 4.8 and not 4.10
On Tue, Jan 20, 2015 at 10:07 PM, Mohit Thakral <[email protected]> wrote: > Sorry, hakeem to me it seems that Nnit is missing in projects like > "Lucene.Net.Facet" and "Lucene.Net.Classification" and there was some issue > with generic type in project "Lucene.Net.Grouping" file "GroupingSearch" > line number 160, 167, thats what I have found till now, i clone around 50 > min, may be I am missing something. > > Regards > Mohit Thakral > > On Tue, Jan 20, 2015 at 8:36 PM, Hakeem Mohammed <[email protected]> > wrote: > > > I didn't add any items that are not compiling to the sln. Just the > folders > > and files are added so that others can start working on the bits. Since > it > > looks like Joshua started on highlighter and Mohit on Join, I'll exclude > > those when I submit my PR. Let me know if anyone has picked up any other > > stuff. Thx > > > > On Tue, Jan 20, 2015 at 9:25 PM, Mohit Thakral <[email protected]> wrote: > > > > > So, I am about to begin work, seems like the solution is not building > > right > > > now. I have created the branch port-join and would start porting the > code > > > for join. I will focus on getting the join project working and make > sure > > > the tests are passed, but what about any dependencies of join, I > suppose > > I > > > can take care of that as well. > > > > > > I will sign the ICLA tommorow before i commit the code. > > > > > > Regards > > > Mohit Thakral > > > > > > On Tue, Jan 20, 2015 at 5:41 PM, Joshua Ball < > [email protected]> > > > wrote: > > > > > > > OK, thanks. > > > > Work has begun ;-) > > > > https://github.com/joshball/lucenenet/tree/port/highlighter > > > > > > > > On Tue, Jan 20, 2015 at 3:26 PM, Itamar Syn-Hershko < > > [email protected]> > > > > wrote: > > > > > > > > > You are now the only one working on the highlighter. So push ur > code > > to > > > > > your fork and when u think its ready for review send us a PR. > > > > > > > > > > If this can be when all tests are green, all the better. > > > > > > > > > > Because you will be working on a branch on your fork, im > indifferent > > to > > > > how > > > > > u do it. We will fix what need to be fixed in the PR stage. > > > > > On Jan 21, 2015 1:11 AM, "Joshua Ball" <[email protected]> > > > > wrote: > > > > > > > > > > > Sorry just want to be clear here, because I saw both 'wait till > > done' > > > > and > > > > > > 'get it up so others can work' ;-) > > > > > > > > > > > > Do you want me (us) to do a PR on the checked in PORT of the > > > > (highlighter > > > > > > only) code so others can work on it as well, or should I wait > until > > > > > > everything builds? Or wait till everything builds AND passes > > tests? > > > > > > > > > > > > If you do want the code checked in prior to building, in another > > > > branch? > > > > > Or > > > > > > master without solution files checked in (so we don't break > > everyone > > > > > > else). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 2:56 PM, Itamar Syn-Hershko < > > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > Yes, all of that needs to be removed and .NETified. You will > find > > > > many > > > > > > Java > > > > > > > replacement data structure and helper functions here: > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Core/Support > > > > > > > (mainly under compatibility). We are still figuring all of that > > out > > > > so > > > > > > feel > > > > > > > free to raise questions.. > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > http://code972.com | @synhershko < > https://twitter.com/synhershko > > > > > > > > > > Freelance Developer & Consultant > > > > > > > Lucene.NET committer and PMC member > > > > > > > > > > > > > > On Wed, Jan 21, 2015 at 12:53 AM, Joshua Ball < > > > > > [email protected] > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Great. > > > > > > > > I assume we don't want the sharpen namespace, right? > > > > > > > > > > > > > > > > For instance, there is code like this (in > gradientformater.cs): > > > > > > > > fgRMin = > HexToInt(Sharpen.Runtime.Substring(minForegroundColor, > > > 1, > > > > > 3)); > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 2:45 PM, Itamar Syn-Hershko < > > > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Simple: > > > > > > > > > > > > > > > > > > git clone (your fork) > > > > > > > > > git branch -b port-highlighter -t origin/master > > > > > > > > > copy the 2 folders you indicated from Hakeem's fork you > > cloned > > > > > > locally > > > > > > > to > > > > > > > > > another dir > > > > > > > > > commit crediting Hakeem for the initial work > > > > > > > > > iterate from here > > > > > > > > > > > > > > > > > > when you are done or the code is ready to be reviewed, git > > push > > > > > > origin > > > > > > > > > port-highlighter > > > > > > > > > > > > > > > > > > This will allow us to create a PR on GitHub's UI > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > http://code972.com | @synhershko < > > > https://twitter.com/synhershko > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > Lucene.NET committer and PMC member > > > > > > > > > > > > > > > > > > On Wed, Jan 21, 2015 at 12:40 AM, Joshua Ball < > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > OK, I am a bit confused about exactly what to pull here, > > > > branches > > > > > > to > > > > > > > > use, > > > > > > > > > > and code to work on. > > > > > > > > > > I have forked the main repo. > > > > > > > > > > I also cloned Hakeem's > > > > > > > > > > Working out of my fork of the main repo, on a private > > branch, > > > > > > should > > > > > > > I > > > > > > > > > just > > > > > > > > > > copy the directories: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/hakeemsm/lucene.net/tree/master/src/Lucene.Net.Highlighter > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/hakeemsm/lucene.net/tree/master/src/Lucene.Net.Tests.Highlighter > > > > > > > > > > > > > > > > > > > > Add all the files, and get to work? > > > > > > > > > > > > > > > > > > > > FYI, I am not entirely sure the amount of work here, so > it > > > may > > > > > take > > > > > > > me > > > > > > > > a > > > > > > > > > > week, depending upon time. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 9:33 AM, Hakeem Mohammed < > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > OK I just faxed the ICLA. I'll send a PR later this > > evening > > > > > after > > > > > > > > > merging > > > > > > > > > > > with master > > > > > > > > > > > > > > > > > > > > > > Mohit, all of my files are already checked into my > fork. > > > You > > > > > can > > > > > > > get > > > > > > > > > them > > > > > > > > > > > now if you want. But thanks for offering to help. > > > > > Unfortunately I > > > > > > > > can't > > > > > > > > > > RDP > > > > > > > > > > > either > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 10:03 AM, Mohit Thakral < > > > > [email protected] > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hakeem, have you tried http with proxy ?? if none of > > > these > > > > > > > works, I > > > > > > > > > can > > > > > > > > > > > > provide you a temp remote desktop on port 80, you > might > > > be > > > > > able > > > > > > > to > > > > > > > > > copy > > > > > > > > > > > > files to it and then push it to git, let me know if I > > can > > > > > help > > > > > > > :). > > > > > > > > > > > > > > > > > > > > > > > > Regards > > > > > > > > > > > > Mohit Thakral > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 8:58 AM, Hakeem Mohammed < > > > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > I will do so later today. Can't connect to git from > > > work > > > > :( > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 9:35 AM, Itamar > Syn-Hershko < > > > > > > > > > > > [email protected]> > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Hakeem, have you signed an ICLA yet? > > > > > > > > > > > > > > > > > > > > > > > > > > > > If so, can you please create a PR with those - we > > > will > > > > > > bring > > > > > > > > them > > > > > > > > > > in > > > > > > > > > > > so > > > > > > > > > > > > > > they are more visible? > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > > > > > > http://code972.com | @synhershko < > > > > > > > > https://twitter.com/synhershko > > > > > > > > > > > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > > > > > > Lucene.NET committer and PMC member > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 3:52 PM, Hakeem Mohammed > < > > > > > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Joshua & others, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I got all the other projects that Itamar listed > > in > > > > his > > > > > > > > > > > "Contributor's > > > > > > > > > > > > > > > guide" email ported including tests for the > ones > > > that > > > > > > have > > > > > > > > been > > > > > > > > > > > > ported. > > > > > > > > > > > > > > you > > > > > > > > > > > > > > > can get the source from my fork > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/hakeemsm/lucene.net > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please note that they were ported using Sharpen > > and > > > > > none > > > > > > of > > > > > > > > > them > > > > > > > > > > > > > compile. > > > > > > > > > > > > > > > Expressions is the only project that is working > > but > > > > > even > > > > > > > that > > > > > > > > > has > > > > > > > > > > > > some > > > > > > > > > > > > > > > failing tests. As Itamar pointed out, please > > > > > communicate > > > > > > > the > > > > > > > > > libs > > > > > > > > > > > > that > > > > > > > > > > > > > > you > > > > > > > > > > > > > > > are working on > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 3:28 AM, Itamar > > > Syn-Hershko < > > > > > > > > > > > > > [email protected]> > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Since we haven't heard from Hakeem yet I'd > say > > > take > > > > > the > > > > > > > > > > > > queryparsers > > > > > > > > > > > > > > and > > > > > > > > > > > > > > > > run with it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > > > > > > > > http://code972.com | @synhershko < > > > > > > > > > > https://twitter.com/synhershko > > > > > > > > > > > > > > > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > > > > > > > > Lucene.NET committer and PMC member > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 3:58 AM, Joshua Ball > < > > > > > > > > > > > > > > [email protected]> > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Whatever is easiest. I can take anything > (it > > > will > > > > > all > > > > > > > be > > > > > > > > a > > > > > > > > > > > > learning > > > > > > > > > > > > > > > > > experience ;-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jan 19, 2015 at 4:07 PM, Itamar > > > > > Syn-Hershko < > > > > > > > > > > > > > > > [email protected]> > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Seems like the highlighter is already > > taken - > > > > > maybe > > > > > > > > > Hakeem > > > > > > > > > > > can > > > > > > > > > > > > > give > > > > > > > > > > > > > > > you > > > > > > > > > > > > > > > > > > access to his code so you can take it > from > > > > there? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > > > > > > > > > > http://code972.com | @synhershko < > > > > > > > > > > > > https://twitter.com/synhershko > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > > > > > > > > > > Lucene.NET committer and PMC member > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 20, 2015 at 12:31 AM, Joshua > > > Ball < > > > > > > > > > > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I would like to help out on this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The highlighter is something I haven't > > > worked > > > > > > with > > > > > > > > > > before, > > > > > > > > > > > or > > > > > > > > > > > > > > > > whatever > > > > > > > > > > > > > > > > > > > needs the help most. > > > > > > > > > > > > > > > > > > > I will wait for your instructions later > > > > today. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jan 19, 2015 at 6:14 AM, Itamar > > > > > > > Syn-Hershko < > > > > > > > > > > > > > > > > > [email protected]> > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > FYI - I just sent this to the dev@ > > list. > > > > If > > > > > > > > there's > > > > > > > > > > > anyone > > > > > > > > > > > > > > > > > interested > > > > > > > > > > > > > > > > > > in > > > > > > > > > > > > > > > > > > > > helping, let's continue the > discussion > > > > > there... > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > We are pushing hard to a Lucene.NET > 4.8 > > > > > release > > > > > > > and > > > > > > > > > > hope > > > > > > > > > > > to > > > > > > > > > > > > > > have > > > > > > > > > > > > > > > > one > > > > > > > > > > > > > > > > > > with > > > > > > > > > > > > > > > > > > > > you very soon. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > > > > > > > > > > > > http://code972.com | @synhershko < > > > > > > > > > > > > > > https://twitter.com/synhershko > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > > > > > > > > > > > > Lucene.NET committer and PMC > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ---------- Forwarded message > ---------- > > > > > > > > > > > > > > > > > > > > From: Itamar Syn-Hershko < > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Mon, Jan 19, 2015 at 4:12 PM > > > > > > > > > > > > > > > > > > > > Subject: Volunteers for further > porting > > > > help? > > > > > > > > > > > > > > > > > > > > To: "[email protected]" < > > > > > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Heya, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Any volunteers to take discrete > pieces > > of > > > > > Java > > > > > > > > Lucene > > > > > > > > > > > 4.8.0 > > > > > > > > > > > > > and > > > > > > > > > > > > > > > > help > > > > > > > > > > > > > > > > > us > > > > > > > > > > > > > > > > > > > > with porting them + their tests? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene/highlighter > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene/queryparser > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene/grouping > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene/join > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please let me know if you are > > interested > > > > and > > > > > we > > > > > > > > will > > > > > > > > > > set > > > > > > > > > > > > you > > > > > > > > > > > > > up > > > > > > > > > > > > > > > > with > > > > > > > > > > > > > > > > > > > > guidance and proper tooling. This > will > > > > > greatly > > > > > > > help > > > > > > > > > us > > > > > > > > > > > > > proceed > > > > > > > > > > > > > > > with > > > > > > > > > > > > > > > > > > > pushing > > > > > > > > > > > > > > > > > > > > Lucene.NET forward and towards a > > release > > > of > > > > > 4.8 > > > > > > > > soon. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Itamar Syn-Hershko > > > > > > > > > > > > > > > > > > > > http://code972.com | @synhershko < > > > > > > > > > > > > > > https://twitter.com/synhershko > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Freelance Developer & Consultant > > > > > > > > > > > > > > > > > > > > Author of RavenDB in Action < > > > > > > > > > > > > http://manning.com/synhershko/> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
