Hi devs, This email is about two of the Store's tests:
* core/Store/TestNRTCachingDirectory.cs - TestNoDir * core/Store/TestFileSwitchDirectory.cs - TestNoDir Essentially, both create temporary directories, delete them, and use its information to create more specific directories (NRTCachingDirectory and FileSwitchDirectory). Just after constructing the latter ones, they assert that those directories do not exist which will be false because the constructors create the directories if they do not exist (in the case of NRTCachingDirectory, the directory is created before calling the constructor using the NewFSDirectory method). Another person already pointed out this in a comment in the first one of the tests. The easy fix for this would be adding deletion instructions after the second round of constructions. But by doing this we could be hiding some other problem under the rug. Two possibilities that come to my mind: 1. They forgot to delete the directories just before the assertions. This seems unlikely to be happening because it would be an obvious bug. 2. The directories' implementations changed over the time but they forgot to change the tests: Maybe, initially, they didn't create the directories if they didn't exist beforehand. Knowing the goal of the test could help deciding. If they wanted to test if they could delete those type of directories, then option 1 could be the right one. If they wanted to test that they don't create directories if they don't exist, the other option would fit better with it. Am I missing out some other possibility? What should we do with those tests? Best regards, Guido
