GitHub user Chand2048 opened a pull request:
https://github.com/apache/lucenenet/pull/77
Fix for
Lucene.Next.Index.TestIndexWriterExceptions.TestSegmentsChecksumError
Learning how to branch properly. The next pull should be cleaner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guidotag/lucenenet ms_chand_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 68ba6d299a8c1beeb8caec024b84b90397372620
Author: Guido Tagliavini Ponce <[email protected]>
Date: 2015-01-15T23:56:39Z
Merge pull request #1 from apache/master
Pulling recent changes.
commit e573fefcda401f15b8c5c9808a4fc4606567ec92
Author: Guido Tagliavini Ponce <[email protected]>
Date: 2015-01-21T19:51:18Z
Merge pull request #2 from apache/master
Pulling recent changes.
commit 9b17d76945d20b8769ee1a2c64e9ca22ab39465f
Author: Guido Tagliavini Ponce <[email protected]>
Date: 2015-01-26T19:02:42Z
Merge branch 'master' of https://github.com/guidotag/lucenenet
commit 06c8bea20a8f91b6f78320895c669ac9af647b38
Author: Guido Tagliavini Ponce <[email protected]>
Date: 2015-01-27T19:51:31Z
Merge remote-tracking branch 'apache/master'
commit ee54ef856ff1c4c50d05caab48b773482131a6ea
Author: Guido Tagliavini Ponce <[email protected]>
Date: 2015-01-29T18:45:32Z
Merge branch 'master' of https://github.com/apache/lucenenet
commit c3b1c25051cafa07ce893f80aa09a862167deec3
Author: Chand2048 <[email protected]>
Date: 2015-02-02T17:53:29Z
The checks in the stack trace to decide where the error was from were using
the wrong variables to get the type of the object the method in the stack was
calling from. Changed frame.GetType().Name to method.DeclaringType.Name and
fixed some casing problems in the constants.
commit 33ea59752c1a5cf2720fcb71f4587cf03feceafe
Author: Chand2048 <[email protected]>
Date: 2015-02-02T19:33:20Z
Missing the IndexWriterConfig was missing SetCheckIntegrityAtMerge method.
C# does not have the synthetic flag so I changed it to look at the
DeclaringType of the method to understand if it was a method from the
LiveIndexWriterConfig. This allowed me to enable the check to ensure all
setters are properly overridden.
commit 6eed981c95d9cc0bb2bcc7da1fe1aee8152d4cc7
Author: Chand2048 <[email protected]>
Date: 2015-02-05T21:03:05Z
Fix for TestSegmentsChecksumError()
Change to throw IOException instead of Exception. The code in
FindSegmentsFile.Run expects the reads to throw an IOException when the file is
corrupt or in some other way invalid like failing the crc32 check. Based on
this exception type, the code will ignore the last segment and continue. This
is what the unit test is looking for.
commit 938fd34adfff0deb71fe15c1ec4c8333b2950a23
Author: Chand2048 <[email protected]>
Date: 2015-02-05T22:57:34Z
Merge remote-tracking branch 'apache/master' into ms_chand_2
commit e937df81554f51db13fd6b347b8216f0ac82b91d
Author: Chand2048 <[email protected]>
Date: 2015-02-06T01:48:23Z
Remove the debug statement I accidentally left in.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
