Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/138#issuecomment-98593927
Good catch
2 things come to mind:
1. `OffsetGap_Renamed` and such other `_Renamed` instances need to be,
well, renamed and have that suffix dropped. It's the converter doings, and it
just makes the code base looks bad
2. I'm sure there are more such places, e.g. nullables that were ported as
value types and somewhere in the code are compared to null, indicating they
should indeed be nullables. R# should highlight those comparisons, but we need
to search for them and inspect one by one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
