Github user EMaher commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/168#discussion_r60832211
  
    --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
    @@ -726,15 +724,15 @@ public override void Run()
                                     {
                                         if (Random().NextBoolean())
                                         {
    -                                        WriterRef.Value.PrepareCommit();
    +                                        WriterRef.PrepareCommit();
                                         }
    -                                    WriterRef.Value.Commit();
    +                                    WriterRef.Commit();
                                     }
    -                                catch (AlreadyClosedException ace)
    +                                catch (AlreadyClosedException)
                                     {
                                         // ok
                                     }
    -                                catch (System.NullReferenceException npe)
    +                                catch (NullReferenceException)
    --- End diff --
    
    I just removed the unnecessary 'System' and removed the unused variable 
declaration.  I'm not sure why it is okay, you'd have to ask the original test 
writer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to