Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/177#discussion_r73789759
--- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs ---
@@ -85,22 +86,22 @@ public static IndexWriter MockIndexWriter(Directory
dir, IndexWriterConfig conf,
/// <summary>
/// create a RandomIndexWriter with a random config: Uses
TEST_VERSION_CURRENT and MockAnalyzer </summary>
- public RandomIndexWriter(Random r, Directory dir)
- : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r,
LuceneTestCase.TEST_VERSION_CURRENT, new MockAnalyzer(r)))
+ public RandomIndexWriter(Random r, Directory dir, Similarity
similarity, TimeZone timezone)
+ : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r,
LuceneTestCase.TEST_VERSION_CURRENT, new MockAnalyzer(r), similarity, timezone))
{
}
/// <summary>
/// create a RandomIndexWriter with a random config: Uses
TEST_VERSION_CURRENT </summary>
- public RandomIndexWriter(Random r, Directory dir, Analyzer a)
- : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r,
LuceneTestCase.TEST_VERSION_CURRENT, a))
+ public RandomIndexWriter(Random r, Directory dir, Analyzer a,
Similarity similarity, TimeZone timezone)
+ : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r,
LuceneTestCase.TEST_VERSION_CURRENT, a, similarity, timezone))
{
}
/// <summary>
/// create a RandomIndexWriter with a random config </summary>
- public RandomIndexWriter(Random r, Directory dir, LuceneVersion v,
Analyzer a)
- : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r, v, a))
+ public RandomIndexWriter(Random r, Directory dir, LuceneVersion v,
Analyzer a, Similarity similarity, TimeZone timezone)
+ : this(r, dir, LuceneTestCase.NewIndexWriterConfig(r, v, a,
similarity, timezone))
{
}
--- End diff --
can you add a LUCENENET comment saying this is specific to the .NET port +
reasoning, so we don't override this change in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
