Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/205
  
    > OK. So I should remove the `[Ignore]` attribute then?
    
    Yes. We should only use the `[Ignore]` attribute in cases where the test 
takes > 30 minutes and must be run manually, or was ignored in Lucene for some 
reason. Otherwise we want the tests to complain if there is something wrong 
with the software.
    
    > The only question I still have is about the timeout. In my tests, if it 
would test, it would test rather quickly. At the moment I have the timeout on 5 
seconds, but it should be fine to lower this to e.g. 1 second or .5 seconds. 
Should I do this?
    
    I would say use your best judgement to set the timeout where it is long 
enough to fail at least 50% of the time on most systems. 5 seconds isn't too 
bad considering a full test run takes around an hour. I don't even consider 
them "long running tests" unless they are upwards of 1 minute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to