Sounds legit to me. Generating and distributing pdb's is the way to go, unless there is something preventing us from doing this. Shad? Connie?
-- Itamar Syn-Hershko Freelance Developer & Consultant Elasticsearch Partner Microsoft MVP | Lucene.NET PMC http://code972.com | @synhershko <https://twitter.com/synhershko> http://BigDataBoutique.co.il/ On Mon, Jun 12, 2017 at 4:55 PM, Van Den Berghe, Vincent < [email protected]> wrote: > Hello everyone, > > I'm seeing the following in AssemblyInfo.cs: > > // LUCENENET NOTE: This attribute is required to disable optimizations so > the > // > Lucene.Net.Tests.Index.TestIndexWriterExceptions.TestExceptionsDuringCommit() > test > // can read the stack trace information, otherwise the test fails. > [assembly: Debuggable(DebuggableAttribute.DebuggingModes.Default | > DebuggableAttribute.DebuggingModes.DisableOptimizations)] > > > This effectively disables optimizations in release mode. > However, removing this attribute is removed doesn't seem to affect the > "TestExceptionsDuringCommit" test. Moreover, this test doesn't seem to read > stack trace information, unless there is something that I'm missing. > > If stack trace information is needed in release mode, one could consider > generating PDB information. Yes, optimization will sometimes cause the > information to be incorrect, but the probability of having bugs in release > mode that can't be reproduced in debug mode is relatively small, IMHO. > > What say the esteemed colleages? > > Vincent >
