Hi Vankadesh, Are these changes being copied into a Lucene.NET 3.x application or to early source code of Lucene.NET 4.8.0 prior to the release on NuGet?
To conform with .NET conventions, we have renamed "close()" in Java to the corresponding method in .NET, "Dispose()" in Lucene.NET 4.8.0. In Java, there is a Closeable interface that has been replaced by the nearest .NET match, IDisposable. As such, we wouldn't want to use "Close()" in .NET unless we are not using "Dispose()" according to .NET best practices (for example, if it is expected that the object will be "opened" again). Hi Michael, We have an open JIRA ticket to review these changes to ensure we are following .NET best practices (https://issues.apache.org/jira/projects/LUCENENET/issues/LUCENENET-626), and another that seemed to point in the direction that TokenStreams were being reopened (https://issues.apache.org/jira/projects/LUCENENET/issues/LUCENENET-611), thus might be better off using "Close()" instead of "Dispose()" in that case. However, a bug was since patched in the TestFramework that may have been the culprit that was causing this "reopen" to occur. We need to do a full assessment from a usability point of view to be sure of which to use, and in what cases, but in general we should use "Dispose()" unless we have a good reason not to. Regards, Shad Storhaug (NightOwl888) Project Chairperson - Apache Lucene.NET -----Original Message----- From: [email protected] <[email protected]> Sent: Thursday, April 9, 2020 2:08 PM To: 'Venkadesh Thangavel' <[email protected]>; [email protected] Cc: 'Gal Ferrera' <[email protected]>; 'Tidhar Israel' <[email protected]>; 'Subramaniyan Hariharan' <[email protected]> Subject: RE: HINDI LANGUAGE ANALYZER FROM LUCENE Dear Venkadesh Thanks so much for your follow up. If necessary, would it be possible for me to incorporate your changes to the source code to benefit other users? Kind regards Michael -----Original Message----- From: Venkadesh Thangavel <[email protected]> Sent: Thursday, April 2, 2020 2:03 PM To: [email protected] Cc: Gal Ferrera <[email protected]>; Tidhar Israel <[email protected]>; Subramaniyan Hariharan <[email protected]> Subject: RE: HINDI LANGUAGE ANALYZER FROM LUCENE Hello Michal, Thanks for your response. Please find the details steps as below. 1. Down load LUCENE.NET latest source code from the below path: for hindi analyzer. https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Analysis.Common/Analysis/Hi 2. We had already LUCENE.NET project to support other languages but we don't want to disturb older one. Hence we used only Hindi analyzer from LUCENE.NET and added to existing LUCENE. 3. We found that it has missing classes, we had added it as separate for HINDI analyzer and subordinate classes without disturbing existing one And compiled source code. 4. And identified that the error is throwing as "close() method is missing" and caused in the file (TokenStream.cs- latest file). 5. Added the virtual method as like below. public virtual void Close() { } 6. This method was override into the following subordinate classes. ClassicTokenizer.cs StandardTokenizer.cs UAX29URLEmailTokenizer.cs CharTokenizer.cs FilteringTokenFilter.cs TokenFilter.cs Now, the problem was resolved and running successfully. Thanks in-Advance. Kindly let us know, if you required any more inputs. Thanks & Regards, Venkadesh T -----Original Message----- From: Gal Ferrera <[email protected]> Sent: 31 March 2020 19:30 To: Venkadesh Thangavel <[email protected]> Subject: Re: HINDI LANGUAGE ANALYZER FROM LUCENE Did you notice? On 31/03/2020, 16:31, "Michael Condillac on behalf of [email protected]" <[email protected] on behalf of [email protected]> wrote: Hi Venkadesh, I am new to the project but if you can give me some more technical details and specific errors you are seeing I can try and reproduce your issues. Thanks Michael -----Original Message----- From: Venkadesh Thangavel <[email protected]> Sent: Tuesday, March 31, 2020 7:15 PM To: [email protected]; [email protected] Cc: Gal Ferrera <[email protected]> Subject: FW: HINDI LANGUAGE ANALYZER FROM LUCENE Hi, I have sent email to [email protected]<mailto:[email protected]> about the issue in LUCENE.NET but didn't receive any response. Can you please comment on my issue ? Thanks & Regards, Venkadesh T From: Venkadesh Thangavel Sent: 19 March 2020 16:40 To: [email protected] Subject: HINDI LANGUAGE ANALYZER FROM LUCENE Hello, I have downloaded LUCENE.NET source code from GITHUB last year mid for Hindi language and used Hindi analyser. I faced some issues while compiling LUCENE regarding close method from analyser and implemented the same in LUCENE . Then it was successfully compiled and used. Is it right behaviour or some went wrong. Kindly suggest. Thanks & Regards, Venkadesh T
