eladmarg commented on issue #346: URL: https://github.com/apache/lucenenet/issues/346#issuecomment-697231411
I understand its complicated, truly I am. but why should we stick to the java bad pattern implementation? who cares, seriously. we all want highly performant search library, and for production use, I really don't want/need overhead debug assertions. 10% performance penalty isn't wroth to be java compliance in this case I strongly feels that move this to #IF TESTING is better option, you still have the whole functionality, you can run all the tests in release/debug and get the same behavior. for production use, we'll compile this without and get the best from both worlds. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
