jeme commented on a change in pull request #347:
URL: https://github.com/apache/lucenenet/pull/347#discussion_r494868101
##########
File path: src/Lucene.Net/Support/Diagnostics/Debugging.cs
##########
@@ -26,6 +26,9 @@ namespace Lucene.Net.Diagnostics
/// </summary>
internal static class Debugging
{
+ // LUCENENET specific - use a lazy wrapper around SystemProperties to
avoid the repeated cost of getting the value
+ private static Lazy<bool> _assertsEnabled = new Lazy<bool>(() =>
SystemProperties.GetPropertyAsBoolean("assert", false));
Review comment:
I don't think this matches the naming convention that Lucene.NET uses, I
haven't seen the Underscore prefix used anywhere in the codebase. I know
Resharper (if your using that, perhaps Lucene.NET should come with a Resharper
config file, it's a rather popular tool after all, although I can't recommend
it for the Lucene project due to it's size >.<) suggests this and it's perhaps
common in the MS codebases, but not here., @NightOwl888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
