NightOwl888 commented on issue #406:
URL: https://github.com/apache/lucenenet/issues/406#issuecomment-771992128


   >Is it available elsewhere where I could take a look at it just to better 
understand what such a test runner looks like?
   
   I have setup a [temporary 
repo](https://dev.azure.com/LuceneNET-Temp/Lucene.NET/_git/NUnit.Xamarin.Android?path=%2Fsrc%2FNUnit.Xamarin.Android%2FTestSuiteInstrumentation.cs)
 so you can have a peek.
   
   ### `BlameListener`
   
   `BlameListener` is a custom class that writes the name of each test before 
it is run so if there is a crash, we know which test caused the crash. I have 
been trying to get the NUnit team to implement such a feature for years.
   
   - [Test log to determine which test last ran when the test runner 
crashed](https://github.com/nunit/nunit3-vs-adapter/issues/381)
   - [How do I determine what exception caused Test Explorer to 
crash?](https://stackoverflow.com/q/45954441)
   
   At least with the .NET 5 SDK, Microsoft finally added the blame-crash option 
to [`dotnet 
test`](https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-test) so 
crashes can be detected, but it would be nice if this didn't have to be built 
for every other runner manually.
   
   > NOTE: In Xamarin, there are problems with how generics are implemented 
that caused infinite recursion in 
[`ArrayEqualityComparer`](https://github.com/NightOwl888/J2N/blob/master/src/J2N/Collections/ArrayEqualityComparer.cs#L85).
 It would have been nearly impossible to track it down without this feature.
   
   -----------------
   
   > Since you were planning on creating the additional testing targets for 
Xamerin that use NUnit 3.10 anyway, do you want to be the one to upgrade the 
other compilation targets to use NUnit 3.17 at the same time? I can do it, but 
it seems like a good fit for you to do it with the other XUnit dependency 
changes.
   
   There is no conflict if you upgrade NUnit to 3.17 globally now (in 
`Dependencies.props`) and the other changes are implemented later, including 
the ability to specify a different version on specific target frameworks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to