NightOwl888 commented on issue #354:
URL: https://github.com/apache/lucenenet/issues/354#issuecomment-772068962


   Given that #381 doesn't seem to solve our issue and we have had no other 
takers, it looks like it is time to deprecate `TaskMergeScheduler`.
   
   ```c#
   [Obsolete("Use ConcurrentMergeScheduler instead. This class will be removed 
in 4.8.0 release candidate."), 
System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
   public class TaskMergeScheduler : MergeScheduler, IConcurrentMergeScheduler
   ```
   
   As part of the deprecation, we need to tear out the 
[`LuceneTestCase.ConcurrentMergeSchedulerFactories`](https://github.com/apache/lucenenet/blob/ae13dc4dfe0b8a2d305b9f8f860ac0849a16ac80/src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs#L3552-L3578)
 and revert all of the tests that depend on it back to their original Java 
Lucene implementation. Other references to `TaskMergeScheduler` should also be 
removed from tests.
   
   We can also remove the tests for `TaskMergeScheduler` altogether, which will 
improve testing run times.
   
   Although it wasn't part of Lucene, we can leave the 
`IConcurrentMergeScheduler` interface in Lucene.NET as it might be in use by 
users already.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to