NightOwl888 commented on issue #413:
URL: https://github.com/apache/lucenenet/issues/413#issuecomment-774144633


   Looks like this is a case of mistaken identity.
   
   There is a 
[TermsQuery](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.8.0/lucene/join/src/java/org/apache/lucene/search/join/TermsQuery.java)
 class in the `join` package which exists in Lucene 4.8.0. This class has never 
been declared public in Lucene.
   
   In Lucene 5.1.0, a new public 
[TermsQuery](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/5.1.0/lucene/queries/src/java/org/apache/lucene/queries/TermsQuery.java)
 class was added to the `queries` package, which is the one the documentation 
link refers to above.
   
   In principle, I don't see any issue with making the `TermsQuery` class in 
`Lucene.Net.Join` public. But I would like to ask the Lucene team why it was 
made package private in the first place. If the Lucene team agrees that it 
should be made public in the current version, then I don't see any reason we 
can't make that change in Lucene.NET 4.8.0. Before I do, I just wanted to check 
which of these 2 different implementations you are referring to when you say 
"it performs better"?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to