NightOwl888 commented on a change in pull request #420:
URL: https://github.com/apache/lucenenet/pull/420#discussion_r575467606
##########
File path: src/Lucene.Net.Tests.Classification/Utils/DataSplitterTest.cs
##########
@@ -32,20 +32,20 @@ namespace Lucene.Net.Classification
*/
public class DataSplitterTest : Util.LuceneTestCase
{
- private AtomicReader _originalIndex;
- private RandomIndexWriter _indexWriter;
+ private AtomicReader originalIndex;
+ private RandomIndexWriter indexWriter;
private Directory _dir;
Review comment:
While either fields with or without an underscore are fine (without
underscore preferred), we should use the same convention within the context of
a single file. Please change this to `dir` as well.
Do note that some classes in `Lucene.Net.Classification` also use a leading
underscore. No objection if you wish to change those as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
