+1 // Simon Svensson
On 2021-03-28 04:04, Laimonas Simutis wrote: > +1 > > On Sat, Mar 27, 2021 at 8:46 PM Shannon Deminick <[email protected]> > wrote: > >> +1 >> >> On Sat, 27 Mar 2021, 05:30 Shad Storhaug, <[email protected]> wrote: >> >>> +1 >>> >>> We got a report today that the lucene-cli tool isn't functioning because >>> it was set up to make the appsettings.json file required instead of >>> optional. It doesn't ship with an appsettings.json file. >>> >>> https://github.com/apache/lucenenet/issues/453#issuecomment-808218724 >>> >>> The last release it worked in was 4.8.0-beta00008. The error message is >>> clear about where the file it is looking for is located and it can be >>> worked around by adding an empty JSON file at that location (that is, a >>> file named appsettings.json with only curly brackets in it). >>> >>> I have updated the release notes of all of the versions that have the >>> issue, including 4.8.0-beta00014, which isn't live yet. But the message >>> hasn't changed and can be viewed in the 4.8.0-beta00013 release notes as >>> well: >>> >>> >> https://github.com/apache/lucenenet/releases/tag/Lucene.Net_4_8_0_beta00013 >>> >>> Normally I would vote to stop a release for something as severe as an >>> error that prevents an app from running, but being that this issue has >> been >>> happening in 9 months in production without one report about it and there >>> is a workaround, I think we should discuss it further. My vote is to >>> continue to release, but I would understand if someone disagrees. The fix >>> is very straightforward and we could restart the vote in no time if we >>> decide stopping the release is preferred. >>> >>> One other minor issue I found is that the copyright date is still 2020, >>> but certainly that isn't a showstopper. >>> >>> The tests all passed in the release and benchmarks have barely changed >>> since 4.8.0-beta00013. >>> >>> >>> -----Original Message----- >>> From: Prescott Nasser <[email protected]> >>> Sent: Friday, March 26, 2021 4:12 AM >>> To: [email protected] >>> Subject: RE: [VOTE] Apache Lucene.NET 4.8.0-beta00014 >>> >>> +1 >>> >>> -----Original Message----- >>> From: Shad Storhaug <[email protected]> >>> Sent: Thursday, March 25, 2021 7:39 AM >>> To: [email protected] >>> Subject: [VOTE] Apache Lucene.NET 4.8.0-beta00014 >>> >>> I have posted a new candidate for the Apache Lucene.NET 4.8.0-beta00014 >>> release and it is ready for testing. >>> >>> >>> >>> The binaries can be downloaded from: >>> >>> https://s.apache.org/dev >>> >>> >>> >>> NOTE: To run the tests on the command line, the .NET 5.0 SDK is now >>> required (although build only can still be done with .NET Core 3.1). >>> >>> https://github.com/apache/lucenenet/#command-line >>> >>> >>> >>> The release was made from the Apache Lucene.NET 4.8.0-beta00014 tag at: >>> >>> https://s.apache.org/4.8.0-beta00014-tag >>> >>> >>> >>> The release notes and benchmarks are listed at: >>> >>> https://s.apache.org/4.8.0-beta00014-notes >>> >>> >>> >>> The test results can be viewed at: >>> >>> https://s.apache.org/4.8.0-beta00014-test >>> >>> >>> >>> >>> >>> The release was made using the Lucene.NET release process, documented on >>> the website: >>> >>> https://lucenenet.apache.org/contributing/make-release.html >>> >>> >>> >>> Please vote on releasing these packages as Apache Lucene.NET >>> 4.8.0-beta00014. The vote is open for at least the next 72 hours, i.e. >>> 15:00 UTC on 2021-03-28 https://s.apache.org/4.8.0-beta00014-countdown >>> >>> >>> >>> >>> >>> Only votes from Lucene.NET PMC are binding, but everyone is welcome to >>> check the release candidate and vote. >>> >>> The vote passes if at least three binding +1 votes are cast. >>> >>> >>> >>> [ ] +1 Release the packages as Apache Lucene.NET 4.8.0-beta00014 >>> >>> >>> >>> [ ] -1 Do not release the packages because... >>> >>> >>> >>> >> >
