rclabo commented on pull request #572: URL: https://github.com/apache/lucenenet/pull/572#issuecomment-993662370
I don't even know how to respond to this. I guess I will just say by intrinsic what I mean is that in java you can `this.signalAll()`. just like you can declare a method to be synchronized. In other words, in java the class can be intrinsically locked by the keyword synchronized and it can be intrinsically signaled on via `signalAll()`. C# has neither of these facilities. So in c# instead of the synchronized keyword we use lock(this) and in c# instead of `this.signalAll()` we can use a `ManualResetEvent` instance and call it's Set() method. And hence calling that instance variable intrinsic is a reminder that we are using the `ManualResetEvent` as a replacement for Java's intrinsic ability to `SignalAll()` the class itself. Anyway, your changes are fine. Feel free to run with them if they pass the two additional tests I crafted when ran manually. The situation just rubs me wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
