NightOwl888 commented on a change in pull request #578:
URL: https://github.com/apache/lucenenet/pull/578#discussion_r768982748
##########
File path: src/Lucene.Net.Facet/FacetResult.cs
##########
@@ -4,6 +4,7 @@
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Text;
+#nullable enable
Review comment:
This is just to enabled the [nullable reference
type](https://docs.microsoft.com/en-us/dotnet/csharp/nullable-references)
feature. It allows us to make it explicit that `IFormatProvider` accepts a
`null` value (which causes it to use the current culture).
I am slowly going through and adding this (rather inconsistently) instead of
making a separate task. Since the project is large, enabling this feature at
the project level isn't practical. While this doesn't seem to make a lot of
sense on small files, enabling this on larger files does help to identify
potential `null` reference bugs so they can be avoided. The whole `J2N` library
was converted to use this and it turned out to be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
