nikcio commented on PR #690: URL: https://github.com/apache/lucenenet/pull/690#issuecomment-1280693267
@NightOwl888 There's two that I couldn't change due to them causing errors these are: https://sonarcloud.io/project/issues?issues=AYPAuN5xhbfJOGLOoaDV&open=AYPAuN5xhbfJOGLOoaDV&id=nikcio_lucenenet https://sonarcloud.io/project/issues?issues=AYPAuOHjhbfJOGLOoaMN&open=AYPAuOHjhbfJOGLOoaMN&id=nikcio_lucenenet I've marked them in SonarCloud. But regarding the rest of the changes in the review phase here I haven't had the time to mark them in SonarCloud yet. Therefore, I think the best approach would be to merge these changes as is and create a new PR with the attributes on the warnings we can rule out like the two links above and the ones that have been caught in the review process here. I think that doing a branch sweep for the warning is a little to early just yet because the new static methods might have opened up for more methods being available to be made static. Therefore, we cannot be sure that the next scan is only the cases we have found to be unable to be marked static. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
