nikcio opened a new issue, #737: URL: https://github.com/apache/lucenenet/issues/737
I can see that most of the issues marked as "bugs" in SonarCloud are `Null pointers should not be dereferenced` which risks throwing a `NullReferenceException` Issues: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS2259&types=BUG&id=nikcio_lucenenet As an example I looked into this issue: https://sonarcloud.io/project/issues?issues=AYPAuPgShbfJOGLOobIN&open=AYPAuPgShbfJOGLOobIN&id=nikcio_lucenenet Here I tracked the newest version of the code down here: https://github.com/apache/lucene/blob/7c130d2f07e00fd8725cf7e22cc268dd4331fbbe/lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/ConvTable.java#L59 Which is similar to the version we have which should therefore mean that the same issue is still present in the Java version too? Therefore I'm wondering what's the best approach for fixing these errors or if they should be fixed at all. It's very possible that it's next to impossible to encounter this error in a real world scenario. (I haven't looked too much into how it's used). And related to this, would it make sense to enable the Nullable feature across the project to give a informative public API for the developers using Lucene.NET? Here we could mark variables and parameters that can be null at some point. This should be possible to do step by step by adding the `#nullable enable` that I can see you've used in some files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
