NightOwl888 commented on PR #746: URL: https://github.com/apache/lucenenet/pull/746#issuecomment-1305604942
> ## Sidenote > Assuming the comment around this `Dispose` method is correct this issue can be removed as intended either in SonarCloud or in source: https://sonarcloud.io/project/issues?issues=AYRH0T17_qq9ReJdi40Q&open=AYRH0T17_qq9ReJdi40Q&id=apache_lucenenet It looks like this was mainly done to prevent the end user from being able to override the default `Dispose(bool)` implementation and forget to call `base.Dispose(disposing);`. We can probably just make the protected `Dispose(bool)` into a virtual method and move the implementation there to address this warning as long as we include doc comments to always call the base implementation when overriding `Dispose(bool)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
