NightOwl888 opened a new pull request, #755: URL: https://github.com/apache/lucenenet/pull/755
Since we have (somewhat confusingly) renamed our token attribute types to conform with .NET conventions: | | Lucene | Lucene.NET | | ---- | ---- | ---- | | Concrete type | XxxAttributeImpl | XxxAttribute | | Interface type | XxxAttribute | IXxxAttribute | We had miswired some of the attributes, using the concrete type instead of the interface. This fixes that as well as: 1. Renames all of the file names back to their original Lucene names (with the exception of the file extension) 2. Updates the documentation that refers to interfaces to show the appropriate type 3. Adds guard clauses to all token attribute members Also included in this PR: 1. **PEROFORMANCE:** `[Lucene.Net.Analysis.Sinks.DateRecognizerSinkFilter`: Prefer `ReadOnlySpan<char>` overloads of `DateTime.TryParse()` and `DateTime.TryParseExact()`, when available. 2. **BREAKING:** `Lucene.Net.Analysis.Kuromoji.Token`: Renamed `IsKnown()` > `IsKnown`, `IsUnknown()` > IsUnknown`, `IsUser()` > `IsUser`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
