NightOwl888 commented on PR #773: URL: https://github.com/apache/lucenenet/pull/773#issuecomment-1328075439
Thanks for the great contribution! Love it. Suggestion for Part 6: Build a custom analyzer and use Lucene.Net.TestFramework to test the implementation. The test framework is underutilized IMO. There aren't many tools out there that come with their own tests that can be used to ensure you build extensions correctly. Of course, the extension doesn't have to be an analyzer, but I think that is one of the most common ones. It would also potentially help us find any usability issues with the test framework, since NUnit is nothing like JUnit so we had to pave our own way to porting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
