laimis commented on code in PR #796:
URL: https://github.com/apache/lucenenet/pull/796#discussion_r1159023306
##########
src/Lucene.Net.Analysis.Common/Analysis/Shingle/ShingleFilter.cs:
##########
@@ -638,8 +638,11 @@ public virtual void Advance()
/// <see cref="outputUnigrams"/> = true.
/// </para>
/// </summary>
- public virtual void Reset()
+ public void Reset()
{
+ // LUCENENET specific - S1699 - marked non-virtual because
calling
+ // virtual members from the constructor is not a safe
operation in .NET.
+
Review Comment:
ShingleFilter has a private CircularSequence class inside of it, so removing
virtual designation is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
