NightOwl888 commented on code in PR #814:
URL: https://github.com/apache/lucenenet/pull/814#discussion_r1161290288
##########
src/Lucene.Net/Store/ByteArrayDataOutput.cs:
##########
@@ -38,26 +39,57 @@ public class ByteArrayDataOutput : DataOutput
public ByteArrayDataOutput(byte[] bytes)
{
- Reset(bytes);
+ // LUCENENET: Changed to call private method to avoid virtual
method call in constructor
+ ResetInternal(bytes, 0, bytes.Length);
Review Comment:
Looks like we missed a potential `NullReferenceException` here. The rest of
this looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
