NightOwl888 opened a new pull request, #820: URL: https://github.com/apache/lucenenet/pull/820
This breaks API compatibility in 2 ways: 1. The `PriorityQueue<T>(int, bool)` constructor was replaced with `PriorityQueue<T>(int, ISentinelFactory<T>)`. 2. The virtual `GetSentinelObject()` method was removed from `PriorityQueue<T>`. This also removes ambiguity since both "prepopulate" had to be specified as "true" in the constructor **AND** the `GetSentinelObject()` method had to be overridden in a subclass for it to work. Now there is a single signal. Pass `null` to **not** populate. Pass a `ISentinelFactory<T>` implementation to populate. This PR also contains some related `null` guard clauses and nullable reference type updates to the API (so it is clear when a `null` is accepted for a given parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
