NightOwl888 commented on code in PR #823: URL: https://github.com/apache/lucenenet/pull/823#discussion_r1165002495
########## src/Lucene.Net/Util/OpenBitSetDISI.cs: ########## @@ -31,6 +32,8 @@ public class OpenBitSetDISI : OpenBitSet /// Also give a maximum size one larger than the largest doc id for which a /// bit may ever be set on this <see cref="OpenBitSetDISI"/>. /// </summary> + [SuppressMessage("CodeQuality", "IDE0079:Remove unnecessary suppression", Justification = "This is a SonarCloud issue")] + [SuppressMessage("CodeQuality", "S1699:Constructors should only call non-overridable methods", Justification = "This class will get removed in later versions of Lucene, see LUCENE-6010")] public OpenBitSetDISI(DocIdSetIterator disi, int maxSize) Review Comment: It is fine if we leave it as is. I was even thinking that maybe we should remove the class since it isn't being referenced, but since it was in 4.8.0 I guess we can keep it in case anyone started using it in the beta. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org