laimis commented on code in PR #821:
URL: https://github.com/apache/lucenenet/pull/821#discussion_r1165014947
##########
src/Lucene.Net.Benchmark/ByTask/PerfRunData.cs:
##########
@@ -98,6 +99,8 @@ public class PerfRunData : IDisposable
private readonly IDictionary<string, object> perfObjects = new
Dictionary<string, object>();
// constructor
+ [SuppressMessage("CodeQuality", "IDE0079:Remove unnecessary
suppression", Justification = "This is a SonarCloud issue")]
+ [SuppressMessage("CodeQuality", "S1699:Constructors should only call
non-overridable methods", Justification = "Required for continuity with
Lucene's design")]
public PerfRunData(Config config)
Review Comment:
Sounds good, will do that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
